Kr180r3500 ultra k #240
Open
Kr180r3500 ultra k #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonschmeisser
requested changes
Aug 24, 2023
| <ul> | ||
| <li>KR 180 r3500_ultra_k - Default</li> | ||
| </ul> | ||
| <p> Joint limits and maximum joint velocities are based on the information found in the online <a href="https://www.kuka.com/-/media/kuka-downloads/imported/8350ff3ca11642998dbdc81dcc2ed44c/0000325893_en.pdf">datasheet</a>. All urdfs are based on the default motion and joint velocity limits, unless noted otherwise. </p> |
There was a problem hiding this comment.
Links tend to get stale so it's preferred to refer to the exact name and revision of the data sheet here instead
| <b>NB</b>: this package currently uses non-valid inertia parameters. </p> | ||
| </description> | ||
| <author>Shaun Edwards</author> | ||
| <maintainer email="[email protected]">Iñigo Moreno</maintainer> |
There was a problem hiding this comment.
Suggested change
| <maintainer email="[email protected]">Iñigo Moreno</maintainer> | |
| <author email="[email protected]">Iñigo Moreno</author> |
and then please add Gijs and me as maintainer unless you want to become a full maintainer for the whole kuka_experimental repo
| </p> | ||
| <p> | ||
| This package contains configuration data, 3D models and launch files | ||
| for KUKA KR 180 manipulators. This currently includes the r3500_ultra_k only. |
There was a problem hiding this comment.
Other packages use the official naming scheme here, R3500 ultra K?
| robot model and configuration you intend to use them with. | ||
| </p> | ||
| <p> | ||
| <b>NB</b>: this package currently uses non-valid inertia parameters. </p> |
There was a problem hiding this comment.
Please remove the inertia data then
Comment on lines
+3
to
+5
| <node name="joint_state_publisher" pkg="joint_state_publisher" type="joint_state_publisher"> | ||
| <param name="use_gui" value="true"/> | ||
| </node> |
There was a problem hiding this comment.
Suggested change
| <node name="joint_state_publisher" pkg="joint_state_publisher" type="joint_state_publisher"> | |
| <param name="use_gui" value="true"/> | |
| </node> | |
| <node name="joint_state_publisher" pkg="joint_state_publisher_gui" type="joint_state_publisher_gui" /> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for kr180 r3500 ultra k