-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make list controller and list hardware components immediately visualize the state. #1606
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1606 +/- ##
=======================================
Coverage 87.60% 87.61%
=======================================
Files 108 108
Lines 9918 9917 -1
Branches 889 889
=======================================
Hits 8689 8689
+ Misses 912 911 -1
Partials 317 317
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the pre-commit jobs failing, the content itself looks good to me.
Thanks @destogl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think we should have something different for |
Indeed I think magenta would be better |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing!
@Mergifyio backport humble |
✅ Backports have been created
|
https://github.com/Mergifyio backport iron |
✅ Backports have been created
|
…ze the state. (#1606) (#1691) (cherry picked from commit cce79eb) Co-authored-by: Dr. Denis <[email protected]>
…ze the state. (backport #1606) (#1690) * Make list controller and list hardware components immediately visualize the state. (#1606) (cherry picked from commit cce79eb) # Conflicts: # ros2controlcli/ros2controlcli/verb/list_hardware_components.py * Apply suggestions from code review * Update list_hardware_components.py * Update list_hardware_components.py --------- Co-authored-by: Dr. Denis <[email protected]>
New output
list_hardware_components
New output
list_controllers