Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make list controller and list hardware components immediately visualize the state. #1606

Merged
merged 5 commits into from
Aug 14, 2024
Merged

Make list controller and list hardware components immediately visualize the state. #1606

merged 5 commits into from
Aug 14, 2024

Conversation

destogl
Copy link
Member

@destogl destogl commented Jul 8, 2024 •
edited
Loading

  1. Colorize the name and state of the hardware component respective to its state.
  2. Colorize the controller name according to its state and make the output more tabular for easier reading.

New output list_hardware_components

Screenshot_20240709_110427-1

New output list_controllers

Screenshot_20240705_212755-1

@codecov Codecov
Copy link

codecov bot commented Jul 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.61%. Comparing base (3bc4e45) to head (40c007a).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1606   +/-   ##
=======================================
  Coverage   87.60%   87.61%           
=======================================
  Files         108      108           
  Lines        9918     9917    -1     
  Branches      889      889           
=======================================
  Hits         8689     8689           
+ Misses        912      911    -1     
  Partials      317      317
Flag Coverage Δ
unittests 87.61% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

saikishor
saikishor approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the pre-commit jobs failing, the content itself looks good to me.
Thanks @destogl

saikishor
saikishor approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmagyar
Copy link
Member

bmagyar commented Jul 16, 2024

I think we should have something different for inactive controllers. Dark green and bright green aren't that different, green suggests it's running...

@saikishor
Copy link
Member

I believe is CYAN right? How about "Magenta"? :|
image

@bmagyar
Copy link
Member

bmagyar commented Jul 18, 2024

Indeed I think magenta would be better

@bmagyar bmagyar changed the title Make list controller and list hardware componets immedaitelly visualizing the state. Make list controller and list hardware componets immediately visualizing the state. Jul 23, 2024
@bmagyar bmagyar changed the title Make list controller and list hardware componets immediately visualizing the state. Make list controller and list hardware components immediately visualize the state. Jul 23, 2024
bmagyar
bmagyar approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing!

@bmagyar bmagyar merged commit cce79eb into master Aug 14, 2024
17 of 18 checks passed
@bmagyar bmagyar deleted the make-cli-output-nicer28 branch August 14, 2024 13:15
@destogl destogl added backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels Aug 16, 2024
@destogl
Copy link
Member Author

destogl commented Aug 16, 2024

@Mergifyio backport humble

mergify bot pushed a commit that referenced this pull request Aug 16, 2024
@destogl @mergify
Make list controller and list hardware components immediately visuali…
088b182 
…ze the state. (#1606)

(cherry picked from commit cce79eb)

# Conflicts:
#	ros2controlcli/ros2controlcli/verb/list_hardware_components.py
mergify bot pushed a commit that referenced this pull request Aug 16, 2024
@destogl @mergify
Make list controller and list hardware components immediately visuali…
b2df182 
…ze the state. (#1606)

(cherry picked from commit cce79eb)
This was referenced Aug 16, 2024
Merged
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 16, 2024

backport humble

✅ Backports have been created

@destogl
Copy link
Member Author

destogl commented Aug 16, 2024

https://github.com/Mergifyio backport iron

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 16, 2024

backport iron

✅ Backports have been created

destogl added a commit that referenced this pull request Aug 16, 2024
@mergify @destogl
Make list controller and list hardware components immediately visuali…
1634124 
…ze the state. (#1606) (#1691)

(cherry picked from commit cce79eb)

Co-authored-by: Dr. Denis <[email protected]>
destogl added a commit that referenced this pull request Aug 16, 2024
@mergify @destogl
Make list controller and list hardware components immediately visuali…
19c52a6 
…ze the state. (backport #1606) (#1690)

* Make list controller and list hardware components immediately visualize the state. (#1606)

(cherry picked from commit cce79eb)

# Conflicts:
#	ros2controlcli/ros2controlcli/verb/list_hardware_components.py

* Apply suggestions from code review

* Update list_hardware_components.py

* Update list_hardware_components.py

---------

Co-authored-by: Dr. Denis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmagyar bmagyar bmagyar approved these changes

@saikishor saikishor saikishor approved these changes

@arne48 arne48 Awaiting requested review from arne48

@erickisos erickisos Awaiting requested review from erickisos

@jaron-l jaron-l Awaiting requested review from jaron-l

@livanov93 livanov93 Awaiting requested review from livanov93

@progtologist progtologist Awaiting requested review from progtologist

Assignees
No one assigned
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@destogl @bmagyar @saikishor