-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Choose different read and write rate for the hardware components #1570
base: master
Are you sure you want to change the base?
[Feature] Choose different read and write rate for the hardware components #1570
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1570 +/- ##
==========================================
+ Coverage 87.30% 87.51% +0.20%
==========================================
Files 108 108
Lines 9866 10020 +154
Branches 890 898 +8
==========================================
+ Hits 8614 8769 +155
Misses 929 929
+ Partials 323 322 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition 👍
Why not just use update_rate
as attribute name (same as for controller_manager
or the controllers)
Please update the docs and add also a paragraph to the release notes.
Sure. I forgot about the docs. I'll update it tomorrow at the earliest. Thanks for reminding me. Well regarding the parameter name, I thought of using different because, we have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the docs 👍
This pull request is in conflict. Could you fix it @saikishor? |
17a20f7
to
bc3d5c2
Compare
Resolved conflicts! |
This pull request is in conflict. Could you fix it @saikishor? |
bc3d5c2
to
84d00da
Compare
@christophfroehlich I've just fixed the conflicts after your merged PR on deprecating mimic stuff |
This pull request is in conflict. Could you fix it @saikishor? |
2540431
to
ca62a0b
Compare
Hello!
This PR helps to obtain different read and write update rates rather than having the same update rate as of the controller manager. With these changes, each and every component can run at their own chosen rate and they update the State and Command interfaces according to that rate. This is very useful for system with different communication layers such as EtherCAT, CAN and Serial. Hope this helps the community.
Thank you