User feedback

[annakrystalli]

Would be great to understand whether folks have tried using the package and whether the materials worked / helped them.

Please feel free to leave any general feedback here, even just that you're trying it. Of course feel free to open specific issues if that makes more sense.

[annakrystalli]

@timtrice did you manage to get it to work?

[tdjames1]

Hi @annakrystalli, I tried to set up a review project but I couldn't get it to find my GitHub user name.

I tried setting up an authorization token to allow access to my email address via GitHub > Settings > Developer settings > Personal access tokens but that didn't resolve the problem.

> sessionInfo()
R version 3.4.1 (2017-06-30)
Platform: x86_64-apple-darwin15.6.0 (64-bit)
Running under: macOS Sierra 10.12.6

Matrix products: default
BLAS: /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libBLAS.dylib
LAPACK: /Library/Frameworks/R.framework/Versions/3.4/Resources/lib/libRlapack.dylib

locale:
[1] en_GB.UTF-8/en_GB.UTF-8/en_GB.UTF-8/C/en_GB.UTF-8/en_GB.UTF-8

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
[1] pkgreviewr_0.0.3

loaded via a namespace (and not attached):
 [1] httr_1.3.1      compiler_3.4.1  magrittr_1.5    R6_2.2.2        tools_3.4.1     withr_2.1.2    
 [7] rstudioapi_0.7  curl_3.2        memoise_1.1.0   knitr_1.20      git2r_0.21.0    jsonlite_1.5   
[13] digest_0.6.15   whoami_1.1.2    devtools_1.13.5

[annakrystalli]

Thanks for the feedback @tdjames1!

Interesting 🤔. So the function uses whoami::gh_username() to identify the github user. What happens when you just run whoami::gh_username() in the console?

[tdjames1]

Yes, I had a look at that function - that's why I tried adding the authorization token. I'd be interested to know if it works for you. Here's the output:

> whoami::gh_username()
Error in fallback_or_stop(fallback, "Cannot find GitHub username for email") : 
  Cannot find GitHub username for email

[maelle]

Cf the discussion in whoami, I'll make a PR there. :-)