🐛 Fix MariaDB apt-key is deprecated failure #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
705261e
to
c512063
Compare
swalkinshaw
reviewed
Apr 19, 2024
roles/mariadb/tasks/main.yml
Outdated
Comment on lines
2
to
12
| - name: Download MariaDB GPG key | ||
| ansible.builtin.get_url: | ||
| url: "https://mariadb.org/mariadb_release_signing_key.asc" | ||
| dest: "/tmp/mariadb_release_signing_key.asc" | ||
| mode: '0644' | ||
|
|
||
| - name: Add the MariaDB GPG key to apt | ||
| ansible.builtin.shell: | ||
| cmd: "apt-key add /tmp/mariadb_release_signing_key.asc" | ||
| args: | ||
| removes: "/tmp/mariadb_release_signing_key.asc" |
There was a problem hiding this comment.
Can we use the built-in url feature of apt_key? https://docs.ansible.com/ansible/latest/collections/ansible/builtin/apt_key_module.html
- name: Add an Apt signing key, uses whichever key is at the URL
ansible.builtin.apt_key:
url: https://ftp-master.debian.org/keys/archive-key-6.0.asc
state: presentThere was a problem hiding this comment.
fatal: [default]: FAILED! => {"after": ["D94AA3F0EFE21092", "871920D1991BC93C"], "before": ["D94AA3F0EFE21092", "871920D1991BC93C"], "changed": true, "fp": "AED4B06F473041FA", "id": "AED4B06F473041FA", "key_id": "AED4B06F473041FA", "msg": "apt-key did not return an error, but failed to add the key (check that the id is correct and *not* a subkey)", "short_id": "473041FA"}
swalkinshaw
reviewed
Apr 19, 2024
swalkinshaw
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue where MariaDB installation fails on the "Add MariaDB APT key" task
Ref https://discourse.roots.io/t/trellis-task-mariadb-add-maria-apt-key-apt-key-is-deprecated/26706
Ref https://discourse.roots.io/t/apt-key-deprecated-should-playbooks-be-updated/26761