Fix/add translators comment #2716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing translators comment (about inclusion error path).
Log1x
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current Sage master, when invoking the
translate(translate:pot) script,wp i18n make-potemits warnings for missing translator comments of code used in the Sage theme:Warning: The string "Search Results for %s" contains placeholders but has no "translators:" comment to clarify their meaning. (app/View/Composers/Post.php:58)Warning: The string "Error locating <code>%s</code> for inclusion." contains placeholders but has no "translators:" comment to clarify their meaning. (bootstrap/app.php:32)In case of
app/View/Composers/Post.php:58there is already atranslatorcomment, but on the wrong line, aswp i18n make-potonly uses those when directly preceding the translation methods, this PR fixes this.In case of
bootstrap/app.php:32thetranslatorcomment is completely missing and added by this PR.