-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix javascript enqueue handle #239
Conversation
Log1x
commented
Jul 8, 2022
- fix(bundle): Fix javascript enqueue handle (Fixes Bug: Javascript not executing in production build since 2.1.0 #238)
- chore(bundle): Add missing docblocks
chore(bundle): Add missing docblocks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem with using +
instead of array_merge()
when it comes to indexed arrays is that it will clobber matching indexes on the 2nd array. So we'll have to figure out a more workable solution, I think, unless entrypoints.json will NEVER have js and mjs keys at the same time. (cc @kellymears)
@QWp6t If a user enables esm it likely will not emit But there may be very good reasons to use mjs and js together, I'm really not sure. I think it's good to support mjs/js both, if possible. It would be pretty easy for users to make a couple small mods and end up in a situation where both keys are present. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀