✨ add support for mjs enqueues #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an entrypoint only contains CSS and no JS, this will cause an error. This fix alleviates that by adding empty arrays for all supported entrypoint extensions when none are contained in the bundle. closes #229
kellymears
reviewed
Jun 26, 2022
Comment on lines
+1
to
+33
| <?php | ||
|
|
||
| namespace Roots\Acorn\Sage\Concerns; | ||
|
|
||
| trait FiltersEnqueues | ||
| { | ||
| /** | ||
| * Add support for MJS. | ||
| * | ||
| * Filter: script_loader_tag | ||
| * | ||
| * @param string $tag | ||
| * @param string $handle | ||
| * @param string $src | ||
| * @return string | ||
| */ | ||
| public function filterScriptLoaderTag($tag, $handle, $src) | ||
| { | ||
| if (! $extension = pathinfo(parse_url($src, PHP_URL_PATH), PATHINFO_EXTENSION)) { | ||
| return $tag; | ||
| } | ||
|
|
||
| if ($extension !== 'mjs') { | ||
| return $tag; | ||
| } | ||
|
|
||
| // remove current type if it's defined | ||
| $tag = preg_replace('/type=["\'][^"\']+["\']/', '', $tag); | ||
|
|
||
| // now add module type | ||
| return str_replace('<script ', '<script type="module" ', $tag); | ||
| } | ||
| } |
kellymears
approved these changes
Jun 26, 2022
5 tasks
QWp6t
added a commit
that referenced
this pull request
Jun 26, 2022
* 🐛 support entrypoints without JS * ✨ add support for mjs entrypoints * ✨ add support for mjs enqueues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've only done some rough testing on this one, but I think it should be good to go.