Added more configuration for external redis #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zurdi15
reviewed
Apr 13, 2024
gantoine
requested changes
Apr 13, 2024
gantoine
approved these changes
Apr 13, 2024
|
@HellLord77 looks good, but i need you to squash your commits and sign that squash commit with a PGP key |
add env vars: REDIS_USERNAME, REDIS_DB Co-Authored-By: Zurdi <[email protected]> Co-Authored-By: Georges-Antoine Assi <[email protected]>
Merged
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more configuration for the external redis instance.
adds two new env vars:
REDIS_USERNAME: allows to specify username when using password (requirepass arg for redis creates "default" user)REDIS_DB: helps separating databases when using single redis shared between multiple apps