CodeMirror 6 editor: Fix searches can't cotain spaces, don't appear immediately after typing @@
#16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
personalizedrefrigerator
changed the title
@@
roman-r-m
reviewed
Mar 2, 2024
| @@ -18,14 +18,16 @@ export default function codeMirror6Plugin(pluginContext: PluginContext, CodeMirr | |||
| const { EditorSelection } = require('@codemirror/state') as typeof CodeMirrorStateType; | |||
|
|
|||
| const completeMarkdown = async (completionContext: CompletionContext): Promise<CompletionResult> => { | |||
| const prefix = completionContext.matchBefore(/[@][@]\w+/); | |||
| // Start completions on @@, match any characters that aren't in "()[]{};>,\n" | |||
| const prefix = completionContext.matchBefore(/[@][@][^()\[\]{};:>,\n]*/); | |||
There was a problem hiding this comment.
just curious, why do you match @@ as [@][@] and not @{2} or even @@ ?
|
Thanks for the update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes a few issues with note search in CodeMirror 6. Specifically,
@@. In CodeMirror 6, it was necessary to type one more character.Testing
@@(without the need to type an additional character)@@followed by part of the note's name#in its title@@Screencast_20240227_080621-1.webm
Note
I plan to create another pull request in the next few minutes that fixes a conflict with the snippets plugin.