Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CodeMirror 6 #10

Merged
merged 6 commits into from
Mar 2, 2024
Merged

Conversation

personalizedrefrigerator
Copy link
Contributor

@personalizedrefrigerator personalizedrefrigerator commented Feb 27, 2024

Summary

This pull request does two things:

  1. Updates the plugin build script. This is required to require CodeMirror 6 packages.
  2. Adds support for the CodeMirror 6-based beta markdown editor.

Notes

Testing

  1. Enable the beta editor
  2. Add an existing tag to a note using the plugin
    • Verify that text is preserved by default
  3. Create a new tag using the plugin
    • Verify that text is still preserved
  4. Disable "keep #tag text in the editor"
  5. Add an existing tag to a note using the plugin
    • Verify that the completion text has been removed
  6. Create a new tag using the plugin
    • Verify that the completion text has been removed
  7. Create a code block
  8. Try to link to a tag from the code block
    • Verify that the tag completion dialog doesn't appear.
  9. Disable the beta editor and repeat steps 1-9.

This has been tested successfully on OpenSUSE Linux in Joplin 2.14.16 on commit 3286b5d.

untitled2.webm

Comment on lines -21 to -22
"i": "^0.3.6",
"npm": "^6.14.11",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i and npm weren't in the original template and seem to be unused. As such, I have removed them here.

Please let me know if they should be added back.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see in git log they were there from the very beginning, not sure why.

@roman-r-m
Copy link
Owner

Thank you for the PR.

@roman-r-m roman-r-m merged commit a3c7d9f into roman-r-m:master Mar 2, 2024
@roman-r-m roman-r-m mentioned this pull request Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants