Refactor1.0

[dlsteuer]

@brianr @coryvirok this is quite a big change, so will need some careful review

[chrisbarmonde]

Looks like a little bit of variable confusion here. Param in the function is $c, but here and in the conditional we're checking for $config.

[dlsteuer]

Thanks @chrisbarmonde fixed with a test now.

[chrisbarmonde]

Well that's about as useful as I'm gonna be. I will say, in my time with PHP, I found it was almost always better to just use empty as opposed to isset or is_null. I feel like in 99.999% of cases, you just care whether the object exists or not (which includes it not being null already). And so if you don't think you'll get a null and you only use isset and then someone inevitably submits a null, you end up with problems. They have a big ol' table with what each of the different functions returns here: https://php.net/manual/en/types.comparisons.php

[dlsteuer]

with the whole empty vs isset you have to really assess what empty means at the comparison point, for example "0" is that empty or not in the particular case where you are testing.