-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor1.0 #94
Refactor1.0 #94
Conversation
Fix errors related to that.
private function setAccessToken($c) | ||
{ | ||
if (isset($_ENV['ROLLBAR_ACCESS_TOKEN']) && !isset($config['access_token'])) { | ||
$config['access_token'] = $_ENV['ROLLBAR_ACCESS_TOKEN']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a little bit of variable confusion here. Param in the function is $c
, but here and in the conditional we're checking for $config
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chrisbarmonde fixed with a test now.
Well that's about as useful as I'm gonna be. I will say, in my time with PHP, I found it was almost always better to just use |
with the whole empty vs isset you have to really assess what empty means at the comparison point, for example "0" is that empty or not in the particular case where you are testing. |
@brianr @coryvirok this is quite a big change, so will need some careful review