Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Adhere to PSR-* #81

Closed
wants to merge 2 commits into from
Closed

WIP - Adhere to PSR-* #81

wants to merge 2 commits into from

Conversation

Crisfole
Copy link
Contributor

Adds check for coding standards.

@Crisfole
Copy link
Contributor Author

Address #77 by complying with PEAR (which seems closest to our current code which doesn't use Namespaces).

This is a WIP: there are 88 non-fixable style errors; mostly missing comments and a bunch of class methods in snake_case (which should be camelCase).

@nocive
Copy link
Contributor

nocive commented Apr 13, 2016

@Crisfole PSR-* is probably what you wish to comply with, rather than PEAR (PEAR will be dead pretty soon anyway) :)

http:https://www.php-fig.org/psr/

@Crisfole
Copy link
Contributor Author

@nocive thanks! Any chance there's a CodeSniffer config for it?

I wasn't thrilled with PSR's namespace rules in particular...it'd be a notable breaking change, and I'm not sure how to gracefully deprecate. It'd need to be a major version change (in which case there's more than one bit I'd like to improve).

@nocive
Copy link
Contributor

nocive commented Apr 13, 2016

adhering to PSR is the way to go moving forward imo, you don't necessarily need to comply with all PSR standards, but PSR-0 and 1 are usually followed by most php projects.
Sure there's a phpcs conf for it, here you go: http:https://cs.sensiolabs.org/

@Crisfole
Copy link
Contributor Author

Gracias! Appreciate the link. 0 and 1 at least? Got it.

@nocive
Copy link
Contributor

nocive commented Apr 13, 2016

Sure, no worries, happy to help.
Feel free to mention me if you need more feedback.

@Crisfole
Copy link
Contributor Author

I'll probably wind up doing this as a giant refactor which will definitely bump major version numbers...

@Crisfole Crisfole changed the title WIP - Adhere to PEAR WIP - Adhere to ~PEAR~ PSR-* Apr 14, 2016
@Crisfole Crisfole changed the title WIP - Adhere to ~PEAR~ PSR-* WIP - Adhere to ~~PEAR~~ PSR-* Apr 14, 2016
@Crisfole Crisfole changed the title WIP - Adhere to ~~PEAR~~ PSR-* WIP - Adhere to PSR-* Apr 14, 2016
@Crisfole Crisfole mentioned this pull request Apr 14, 2016
@dlsteuer
Copy link
Contributor

I'm going to close this pull request, the PSR standards are in the refactor1.0 branch

@dlsteuer dlsteuer closed this Jun 14, 2016
@jessewgibbs jessewgibbs deleted the adhere-to-pear branch January 6, 2017 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants