Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ci tests for --prefer-lowest #624

Merged
merged 5 commits into from
Apr 29, 2023
Merged

chore: add ci tests for --prefer-lowest #624

merged 5 commits into from
Apr 29, 2023

Conversation

Chris53897
Copy link
Contributor

Will replace #618
IDE would not allow squash it. A new PR was just faster for me

@danielmorell danielmorell self-requested a review April 28, 2023 15:26
Copy link
Collaborator

@danielmorell danielmorell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you @Chris53897!

I think I have a fix for the failing test on the lowest run. I'll submit that in a separate PR.

@danielmorell danielmorell added the Type: Maintenance General up-keep, or changes that tidy an existing component or process. label Apr 28, 2023
@danielmorell danielmorell merged commit fa4b748 into rollbar:master Apr 29, 2023
@Chris53897 Chris53897 deleted the chore/add-test-prefer-lowest branch April 30, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance General up-keep, or changes that tidy an existing component or process.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants