Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #617 RollbarLogger:log() not compatible with psr/log 1 #623

Merged
merged 2 commits into from
Apr 21, 2023

Conversation

danielmorell
Copy link
Collaborator

Description of the change

This resolves the psr/log 1 compatibility issue in #617. Removing the type annotations does not break compatibility with psr/log 2 and 3, and seems like the best course of action. In the future if we remove support for psr/log 1 we can reinsert the type annotations.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@danielmorell danielmorell added the Type: Bug Fix a component so that its behavior aligns with its documentation. label Apr 20, 2023
@danielmorell danielmorell added this to the v4.0.1 milestone Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Fix a component so that its behavior aligns with its documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RollbarLogger::log() incompatible with Psr\Log\LoggerInterface::log() v1.0
2 participants