Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/chore add test prefer lowest wip (drop support of psr/log 1) #620

Closed
wants to merge 18 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: add ci tests for --prefer-lowest, check psr/log fix
  • Loading branch information
Chris8934 committed Apr 17, 2023
commit e1f48dd17b9b94aa0948acc0cc23236c5dae9b0a
6 changes: 3 additions & 3 deletions .github/workflows/ci-3.x.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,12 @@ jobs:
# Our code has paths for with- and without- XDebug, and we want to test
# both of them.
# @see https://xdebug.org/docs/all_settings#mode
xdebug3-mode: [ "xdebug.mode=develop,coverage", "xdebug.mode=coverage" ]
xdebug3-mode: ['develop,coverage', 'coverage']
include:
- php: '8.0'
os: 'ubuntu'
dependency: 'lowest'
xdebug3-mode: "xdebug.mode=develop,coverage"
xdebug3-mode: 'develop,coverage'

name: PHP ${{ matrix.php }} on ${{ matrix.os }}, ${{ matrix.dependency }} dependencies preferred, ${{ matrix.xdebug3-mode }}
runs-on: ${{ matrix.os }}-latest
Expand All @@ -69,7 +69,7 @@ jobs:
with:
php-version: ${{ matrix.php }}
extensions: curl
ini-values: zend.exception_ignore_args=Off, ${{ matrix.xdebug3-mode }}
ini-values: zend.exception_ignore_args=Off, xdebug3-mode="${{ matrix.xdebug3-mode }}"
coverage: xdebug

- name: Get composer cache directory
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,12 @@ jobs:
# Our code has paths for with- and without- XDebug, and we want to test
# both of them.
# @see https://xdebug.org/docs/all_settings#mode
xdebug3-mode: ["xdebug.mode=develop,coverage", "xdebug.mode=coverage"]
xdebug3-mode: ['develop,coverage', 'coverage']
include:
- php: '8.0'
os: 'ubuntu'
dependency: 'lowest'
xdebug3-mode: "xdebug.mode=develop,coverage"
xdebug3-mode: 'develop,coverage'

name: PHP ${{ matrix.php }} on ${{ matrix.os }}, ${{ matrix.dependency }} dependencies preferred, ${{ matrix.xdebug3-mode }}
runs-on: ${{ matrix.os }}-latest
Expand All @@ -59,7 +59,7 @@ jobs:
with:
php-version: ${{ matrix.php }}
extensions: curl
ini-values: zend.exception_ignore_args=Off, ${{ matrix.xdebug3-mode }}
ini-values: zend.exception_ignore_args=Off, xdebug3-mode="${{ matrix.xdebug3-mode }}"
coverage: xdebug

- name: Get composer cache directory
Expand Down