Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #571 added null check on $filename #572

Merged
merged 1 commit into from
May 13, 2022
Merged

Fixed #571 added null check on $filename #572

merged 1 commit into from
May 13, 2022

Conversation

danielmorell
Copy link
Collaborator

Description of the change

This PR fixes #571 by ensuring $filename is not null.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@danielmorell danielmorell added the Type: Bug Fix a component so that its behavior aligns with its documentation. label May 13, 2022
cyrusradfar
cyrusradfar approved these changes May 13, 2022
View reviewed changes
Copy link

@cyrusradfar cyrusradfar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@danielmorell danielmorell merged commit 63245d7 into master May 13, 2022
@danielmorell danielmorell deleted the fixed_571 branch May 13, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyrusradfar cyrusradfar cyrusradfar approved these changes

Assignees
No one assigned
Labels
Type: Bug Fix a component so that its behavior aligns with its documentation.
Projects
None yet
Milestone
No milestone
2 participants
@danielmorell @cyrusradfar