Improve param scrubbing #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, thanks! We'll review and get this merged shortly. |
| $scrubbed[$k] = str_repeat('*', $count); | ||
| if ($this->_key_should_be_scrubbed($k, $potential_regex_filters)) { | ||
| $scrubbed[$k] = $this->_scrub($v); | ||
| } elseif (is_array($v)) { |
There was a problem hiding this comment.
If I'm reading this correctly, the behavior here is:
- If the key matches a scrub pattern, then scrub it, no matter what its value is (i.e. even if the value is an array)
- Otherwise, if it's an array, recursively scrub params in that array
I think that sounds like the right thing to do, but I just thought I'd shine some light. Perhaps there should be a test for this?
There was a problem hiding this comment.
yeah, that's intended. test has been amended here: cdcb2f1
|
This is up now on packagist as version 0.12.0. Thanks again! |
|
awesome thanks for the fast turnaround on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds several improvements to param scrubbing:
scrub_fieldslist. ex:$config['scrub_fields'] = array('/password/i');$_GETand headers are also scrubbed before being recorded