Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Support psr/log 3 #564

Closed
wants to merge 1 commit into from
Closed

WIP: Support psr/log 3 #564

wants to merge 1 commit into from

Conversation

matt-h
Copy link
Contributor

@matt-h matt-h commented Mar 31, 2022

Description of the change

Please include a summary of the change and which issues are fixed.
Please also include relevant motivation and context.

Update composer to support psr/log 3, most other packages support that now.

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matt-h matt-h changed the title Support psr/log 3 Draft: Support psr/log 3 Mar 31, 2022
@matt-h matt-h changed the title Draft: Support psr/log 3 WIP: Support psr/log 3 Mar 31, 2022
@matt-h matt-h closed this Mar 31, 2022
@Lachie-Young
Copy link

Hey @matt-h,

Currently running into the same issue where I cannot install rollbar-php-laravel into the latest Laravel 9 project as it is using psr/log v3 which this package is not yet updated for.

Curious as to why this pull request was closed and/or if there's anything I can assist with to move this forward?

@danielmorell
Copy link
Collaborator

@Lachie-Young psr/log v3 would require a major version release since it requires the void return type on methods. You can read more about this here rollbar/rollbar-php-laravel#128 (comment).

To resolve your installation issue, try this...

composer require rollbar/rollbar --update-with-dependencies

@matt-h
Copy link
Contributor Author

matt-h commented Apr 11, 2022

I closed the PR because I couldn't actually get it working and didn't want to spend more time on it. As danielmorell mentioned using the --with-all-dependencies flag allows you to use v2 which works just fine.

@Lachie-Young
Copy link

Thanks for your speedy replies @danielmorell @matt-h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants