Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update comment line number #563

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Update comment line number #563

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update comment line number 
I noticed the line number change when viewing the changes here: https://github.com/rollbar/rollbar-php/pull/562/files

and just wanted to fix the comment for you.
  • Loading branch information
@matt-h
matt-h committed Mar 31, 2022
commit 68717c2596f68a9a6fd78075e7950623d921e409
2 changes: 1 addition & 1 deletion tests/DataBuilderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -921,7 +921,7 @@ public function testFramesOrder()
'tests/DataBuilderTest.php',
$frames[count($frames)-1]->getFilename()
);
// 900 is the line number where the comment "// A" is found
// 919 is the line number where the comment "// A" is found
$this->assertEquals(
919,
$frames[count($frames)-1]->getLineno(),
Expand Down