Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Person ID not cast to string #562

Merged
merged 2 commits into from
Mar 30, 2022
Merged

Fixed Person ID not cast to string #562

merged 2 commits into from
Mar 30, 2022

Conversation

danielmorell
Copy link
Collaborator

Description of the change

This resolves rollbar/rollbar-php-laravel#134. It simply casts the ID to a string before it is passed to the Person constructor as suggested by @matt-h.

I have also added a new test to make sure we don't have a regression of this in the future.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@danielmorell
Copy link
Collaborator Author

I never updated the changelog and version for the last two releases. The last commit fixes that.

Copy link

@cyrusradfar cyrusradfar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, lgtm.

@danielmorell danielmorell merged commit 0d11475 into master Mar 30, 2022
@danielmorell danielmorell deleted the fixed_134 branch March 30, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal error after upgrading to 7.2.0
2 participants