Tracechain must implements ContentInterface to be part of Body. #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmorell
requested changes
Mar 11, 2022
There was a problem hiding this comment.
Thank you for your submitting this update! Could we make one small change? Let's also include the SerializerInterface. Otherwise we will be running into some deprecation warnings.
class TraceChain implements SerializerInterface, ContentInterface
Could you add a new commit that includes both interfaces? Thank You!
danielmorell
approved these changes
Mar 11, 2022
|
You're welcome :) 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
In current release (3.1.0), When TraceChain is given to Body, an exception is given because TraceChain does not implements ContentInterface.
Type of change
Related issues