Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing transformer config option #540

Conversation

danielroehrig
Copy link
Contributor

This is needed to specify a transformer in Symfony. Otherwise, the transformer configuration option is not recognized and an error is thrown.

Description of the change

Added "transformer" to the list of config options.

Related issues

rollbar/rollbar-php-symfony-bundle#65

This is needed to specify a transformer in Symfony. Otherwise, the transformer configuration option is not recognized and an error is thrown.
@bxsx
Copy link
Contributor

bxsx commented Oct 29, 2021

Hey @danielroehrig and thanks for the PR 👌

I would like to merge it, but we need to make our CI happy first ;)
I'm afraid I don't have write access to the downstream, so can I have you replace tabs with spaces and add a trailing comma?

@bxsx bxsx self-assigned this Oct 29, 2021
Replace tabs with spaces and add trailing comma
@danielroehrig
Copy link
Contributor Author

danielroehrig commented Nov 1, 2021

Like this?

I always hit the close button. Please ignore my incompetence.

@bxsx
Copy link
Contributor

bxsx commented Nov 2, 2021

Thanks @danielroehrig !

The branch appears to be out of sync with master. Could you merge branch master into your branch?

@danielroehrig
Copy link
Contributor Author

danielroehrig commented Nov 2, 2021

I needed to have the change in an older branch. We are still on 2.1, But I can also update the master branch.

@danielroehrig
Copy link
Contributor Author

Added a new pull request directly for master. Use that and close this one.

@bxsx
Copy link
Contributor

bxsx commented Nov 2, 2021

Thanks, @danielroehrig !

I close this PR as it's a duplicate of #543 now.

I needed to have the change in an older branch. We are still on 2.1, But I can also update the master branch.

Both PRs seem to be based on the 3.0.0 version.

I'll merge #543 and backport it to the 1.x/2.x versions in separate PRs.

@bxsx bxsx closed this Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants