Extended Object Normalization #497
Conversation
- Added better support for serializing common types of classes since a lot of classes use private fields which make the default object normalization basically useless Signed-off-by: RJ Garcia <[email protected]>
ragboyjr
force-pushed
the
extended-object-normalization
branch
from
331bd30
to
0e6ce04
Compare
bishopb
added
Rank: 3 - Minor
|
|
||
| try { | ||
| if (method_exists($obj, 'toString')) { | ||
| $serialized['value'] = $obj->toString(); |
There was a problem hiding this comment.
The method toString we would think would return a string, however that's not guaranteed: someone could do function toString(): resource { return fopen($this->path, 'r'); }. Recommend that the output of $obj->toString() pass through serializeForRollbar to ensure it's serialized. That may require some juggling of the checks.
| $serialized['value'] = $obj->toString(); | ||
| } elseif (method_exists($obj, '__toString')) { | ||
| $serialized['value'] = (string) $obj; | ||
| } elseif (method_exists($obj, 'toArray')) { |
There was a problem hiding this comment.
Same applies here as it did with the toString comment: there's no guarantee that toArray actually returns an array.
| } | ||
| } catch (\Throwable $e) { |
There was a problem hiding this comment.
Throwable is not safe for 5.x, which this version of the Rollbar library supports. We also need a Exception block to handle that version.
| @@ -0,0 +1,11 @@ | |||
| <?php | |||
|
|
|||
| namespace Rollbar\TestHelpers\ObjectSerialization; | |||
There was a problem hiding this comment.
Nit: these may not pass linting, as we have namespace beside the <?php in other files. However, we will be changing this in the next major iteration of this library in order to support strict_types.
bishopb
added
Status: 2 - Accepted
|
I am closing this PR as it has become stale. |
types of classes since a lot of classes use
private fields which make the default object
normalization basically useless
Signed-off-by: RJ Garcia [email protected]
Description of the change
Type of change
Related issues
Checklists
Development
Code review