Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Error when handling invalid reponses from rollbar in php7.4. #485

Merged
merged 2 commits into from
May 1, 2020

Conversation

lxlang
Copy link

@lxlang lxlang commented Apr 29, 2020

Mitigating Array-style access of non-arrays in php 7.4

Prevents ErrorException: Trying to access array offset on value of type null.

Tobias Lang added 2 commits April 22, 2020 15:10
Mitigating Array-style access of non-arrays in php 7.4

Prevents ErrorException: Trying to access array offset on value of type null.
Copy link
Contributor

@icsahn-rollbar icsahn-rollbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Can you please update ReadMe to reflect additional support of 7.3 and 7.4

@mrunalk
Copy link
Contributor

mrunalk commented May 1, 2020

@icsahn-rollbar, I can update the docs. Thanks @lxlang for adding the support for 7.3 and 7.4. We welcome contributions from the community.

@mrunalk mrunalk merged commit a1e0c45 into rollbar:master May 1, 2020
mrunalk pushed a commit that referenced this pull request May 2, 2020
This should fix the build broken by #485
@mrunalk
Copy link
Contributor

mrunalk commented May 8, 2020

@lxlang, we had to revert your change due to our travis builds not able to setup for 7.3 and 7.4 properly. But with #486 we have fixed the issue. Can you please test it and see if that solves your issue. Appreciate your feedback!

@fgilio
Copy link

fgilio commented Jun 2, 2020

@mrunalk so this needs to be merged again? I'm having this same issue rollbar/rollbar-php-laravel#99 in with v6.0.0 and PHP 7.4

@lxlang
Copy link
Author

lxlang commented Jun 8, 2020

@mrunalk

Thanks for your patience.

This change looks fine for me and I would really appreciate seeing this in a new release.
Currently we have many problems with our rollbar integration because of this error.

@fgilio
Copy link

fgilio commented Jun 11, 2020

Meanwhile, we resorted to overloading the class in Composer to patch the issue. It's working fine 👍🏼

@lxlang
Copy link
Author

lxlang commented Jun 19, 2020

That's great, but without a new release, I cannot utilize this change in my systems.

@fgilio
Copy link

fgilio commented Jul 16, 2020

That's great, but without a new release, I cannot utilize this change in my systems.

@lxlang 👋🏼 it's now tagged here https://github.com/rollbar/rollbar-php/releases/tag/v2.1.0

Thanks for the fix

@mrunalk
Copy link
Contributor

mrunalk commented Jul 18, 2020

@lxlang @fgilio thank you for your patience. Yep it's now available as part of 2.1.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants