Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Issue 404: Performance Benchmark for Rollbar:init() #406

Merged
merged 10 commits into from
Sep 6, 2018

Conversation

ArturMoczulski
Copy link
Contributor

@ArturMoczulski ArturMoczulski commented Aug 31, 2018

This PR addresses performance problems brought up here #404

  • Turned off autodetecting Git branches by default and added autodetect_branch configuration option resulted in ~30% performance increase. Code branch was a rarely used feature anyway and turning it off by default make the SDK perform faster for most users.

@ArturMoczulski
Copy link
Contributor Author

There is also another performance spike in <cycle 1> and Composer autoloading as visible in the attached screenshot. I'm working on understanding those two elements as well and see if there is room for optimization there as well.

screen shot 2018-08-31 at 12 27 44 am

@ArturMoczulski
Copy link
Contributor Author

Needs benchmarking on HHVM

@ArturMoczulski ArturMoczulski merged commit 8e0194f into master Sep 6, 2018
@ArturMoczulski ArturMoczulski added this to the v1.6.4 milestone Oct 18, 2018
@ArturMoczulski ArturMoczulski self-assigned this Oct 18, 2018
@ArturMoczulski ArturMoczulski modified the milestones: v1.6.4, v1.6.3 Oct 18, 2018
@bishopb bishopb deleted the 404-init-performance branch December 31, 2020 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant