Fixes for backtraces with poorly specified PHP behavior #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, PHP does not provide a line number and filename in a debug_backtrace(), including cases where call_user_function() is used. We must supply fake values, since the function name is still useful to log. Also, in an Exception's getTrace(), the first frame does not include a line and filename, but that information can be retrieved from the Exception's getFile() and getLine() methods. Lastly, since debug_backtrace() will always include the erroring line, don't force include it, to avoid an inaccurate and misleading stack trace.
brianr
pushed a commit
that referenced
this pull request
Oct 2, 2012
- fixed position of "top level" frame in the backtrace - reverse backtrace so it's in the order Ratchet expects it - new config variable: shift_function. When true (the default), function names are shifted down one level in the trace so that they reflect the context of the call, as Ratchet expects and most other langauges do. - fix notice when $frame['line'] or $frame['file'] is missing. Also bumping version number to 0.3.1.
|
Thanks for this. While reviewing this changeset, I noticed that there were some other problems with the order of the frames in the backtraces. I've incorporated your changes and made a few additional changes that I think put the frames in the most logical order. See this commit: ratchetio@ce2b153 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, PHP does not provide a line number and filename in a
debug_backtrace(), including cases where call_user_function() is used.
We must supply fake values, since the function name is still useful to log.
Also, in an Exception's getTrace(), the first frame does not include
a line and filename, but that information can be retrieved from the Exception's
getFile() and getLine() methods.
Lastly, since debug_backtrace() will always include the erroring line,
don't force include it, to avoid an inaccurate and misleading stack trace.