Fixed E_NOTICE: Undefined property: Rollbar\Defaults::$defaultGitBranch #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When 'allow_exec' is set to false, E_NOTICE errors are generated with every request due to $this->defaultGitBranch variable not being defined because of false condition. This change implements more robust value caching that is used only when $allowExec parameter is set to true, which is a less suprising behavior.
|
Fixes #374 |
|
This looks great. Thank you for PR and tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
'allow_exec'is set tofalse,E_NOTICEerrors are generated with every request due to$this->defaultGitBranchvariable not being defined because of false condition.This change implements more robust value caching that is used only when
$allowExecparameter is set totrue, which is a less suprising behavior.