Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Issue #225: Allow custom JS addition in RollbarJsHelper #235

Merged
merged 1 commit into from
Jul 28, 2017
Merged

GitHub Issue #225: Allow custom JS addition in RollbarJsHelper #235

merged 1 commit into from
Jul 28, 2017

Conversation

ArturMoczulski
Copy link
Contributor

This PR adds support for injecting custom Javascript through RollbarJsHelper as per request in issue #225 .

Ready for review.

@ArturMoczulski ArturMoczulski mentioned this pull request Jul 21, 2017
Closed
coryvirok
coryvirok reviewed Jul 23, 2017
View reviewed changes
Copy link
Contributor

@coryvirok coryvirok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The only thing I think we should add is an explicit semicolon after the JS tag and before the custom JS.

@rokob
Copy link
Contributor

rokob commented Jul 28, 2017

I'm going to merge this and then add the explicit semicolon

@rokob rokob merged commit bed9404 into rollbar:master Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coryvirok coryvirok coryvirok left review comments

@rokob rokob Awaiting requested review from rokob

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ArturMoczulski @rokob @coryvirok