Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Issue #227: Add curl_error() to check for log submission failures #231

Merged
merged 5 commits into from
Jul 21, 2017
Merged

GitHub Issue #227: Add curl_error() to check for log submission failures #231

merged 5 commits into from
Jul 21, 2017

Conversation

ArturMoczulski
Copy link
Contributor

This PR injects result of curl_error() into the Response object in case of curl request problems.

Ready for review.

@ArturMoczulski
Copy link
Contributor Author

ArturMoczulski commented Jul 19, 2017 •
edited
Loading

This is ready for review in PR #231

The result of curl_error() is injected into Response object under info property and available through getInfo(). @and-megan let me know if this makes diagnosing your issues easier.

coryvirok
coryvirok suggested changes Jul 19, 2017
View reviewed changes
Copy link
Contributor

@coryvirok coryvirok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. While you're at it, can you change this comment in CurlSender.php?

"A lot of this class is ripped off from Segment:"
to
"Adapted from ..."

@ArturMoczulski ArturMoczulski merged commit e740348 into rollbar:master Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coryvirok coryvirok coryvirok requested changes

@rokob rokob Awaiting requested review from rokob

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ArturMoczulski @coryvirok