Add emergency, alert, notice to supported levels (PSR3) #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reason we have the specific levels that we do have is due to the Rollbar backend spec at https://rollbar.com/docs/api/items_post/ This change looks fine to me, but it may require a backend change for handling these "unknown" levels. |
|
@rokob Could we map the unknown levels to the known ones? i.e. map 'emergency' to 'critical' |
|
Ok, maybe this #193 could help? |
|
Thx @vdechenaux for submitting a great PR with mapped PSR3 levels to Rollbar levels. This is going to move forward as #140 and pulled into other Level-related work I'm doing right now. |
|
Closing in favor of #193 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR added a throw of a Psr exception, #131 , but some standards levels are not supported...
The priority are based on https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-3-logger-interface.md#11-basics which redirects to https://tools.ietf.org/html/rfc5424#section-6.2.1 ( end of 6.2.1 )