Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing for existance of exec() #172

Merged
merged 1 commit into from
May 19, 2017
Merged

Testing for existance of exec() #172

merged 1 commit into from
May 19, 2017

Conversation

hellopablo
Copy link
Contributor

Tests for existence of exec() function so as not to raise notices on systems where "exec() has been disabled for security reasons".

@rokob
Copy link
Contributor

rokob commented May 19, 2017

LGTM

@rokob
Copy link
Contributor

rokob commented May 19, 2017

I took me some digging to confirm that function_exists actually returns false for disabled functions, because there are a lot of things online saying that it will return true but just error out. It seems that as of at least 5.3+ if a function is disabled via the ini file then this method will work. I think that is good enough.

@rokob rokob merged commit 33725b2 into rollbar:master May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants