GitHub Issue #38: truncate payload #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rokob
reviewed
May 16, 2017
| 'environment' => 'tests' | ||
| )); | ||
|
|
||
| $strategy = new FramesStrategy($databuilder); |
|
This looks very good, I'll give it another once over to see if we can get this merged today. |
rokob
reviewed
May 16, 2017
src/Truncation/FramesStrategy.php
Outdated
| class FramesStrategy extends AbstractStrategy | ||
| { | ||
|
|
||
| const FRAMES_OPTIMIZATION_RANGE = 150; |
There was a problem hiding this comment.
This probably comes from matching what the Gem does, but I feel like it is really large. Maybe we can make this 75 instead so that we get 150 total frames rather than 300 when we truncate.
|
Tests pass, but lint doesn't like the long lines in the tests. Should be a simple fix then we can merge this and release 1.1 |
|
Okay, this is ready for merging |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Truncation is ready for review. This was implemented to resemble truncation strategies from the Ruby notifier as close as possible.