Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check ignore [Fixes #151] #152

Merged
merged 7 commits into from
May 8, 2017
Merged

Fix check ignore [Fixes #151] #152

merged 7 commits into from
May 8, 2017

Conversation

rokob
Copy link
Contributor

@rokob rokob commented May 4, 2017

According to our docs and the old behaviour we pass three parameters to the user supplied checkIgnore function. The new library broke that. This brings the old behaviour back.

@bretto36
Copy link

bretto36 commented May 8, 2017

How long does a merge normally take? Really need this before i pay for rollbar. We occasionally have a DB server that fails and it generally uses up our limit in a day if someone isn't fast enough to fix it. Want to go the paid model but don't want to waste my money

@rokob
Copy link
Contributor Author

rokob commented May 8, 2017 via email

@bretto36
Copy link

bretto36 commented May 8, 2017

Thanks @rokob

@rokob rokob merged commit 6e25838 into master May 8, 2017
@rokob rokob deleted the fix-checkIgnore branch May 16, 2017 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants