Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Issue #72: status 200 when using set_exception_handler #142

Conversation

ArturMoczulski
Copy link
Contributor

@ArturMoczulski ArturMoczulski commented Apr 29, 2017

This changes the exception handler to trigger logging with Rollbar and follow with the default PHP global exception handler instead of overriding it. This effectively brings back the default PHP behavior for uncaught exceptions which is:

if (php_ini.display_errors == 1) {
    show error info
    HTTP RESPONSE CODE 200
} else {
    HTTP RESPONSE CODE 500
}

…er causes HTTP rc 500 on display_errors=0 by default; just have to restore it after logging with Rollbar
@ArturMoczulski ArturMoczulski changed the title GitHub Issue #17: status 200 when using set_exception_handler GitHub Issue #72: status 200 when using set_exception_handler Apr 29, 2017
@ArturMoczulski ArturMoczulski deleted the github-17-set-exception-handler branch April 29, 2017 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant