GitHub Issue #127: Add the request body to the item payload #133
Conversation
…instances are being used between file_put_contents and file_get_contents
ArturMoczulski
changed the title
|
This PR is failing to build in Travis due to a bug in tests/DataBuilderTest.php no related to the issue. The bug is fixed in #126 PHPUnit will be passing once both PRs come together. |
|
This looks good, can you rebase on master now that #126 has been merged just so we can be sure the tests pass. |
|
Is there some way we can ignore those style warnings in the mock? |
|
Failure on hhvm only? That looks suspicious. |
|
Yeah, I'm looking into it. Started setting up hhvm on my dev environment last night. |
|
I'm still not exactly sure what's the convention for providing the level for log method. Some places use \Rollbar\Payload\Level::fromName() others the PHPUnit's LogLevel. However, both are static calls (to a method or a constant). Not sure how we would change this to not use static calls in this case. |
… and stream_read is called in hhvm - in hhvm stream_read is not invoked unless stream_eof returns a valid value
|
This is ready for merge. HHVM is passing now. |
|
🚀 |
This PR covers #127
Added raw request body to the payload. This should be automatically scrubbed with changes coming from #126