Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Issue #127: Add the request body to the item payload #133

Merged
merged 8 commits into from
Apr 27, 2017

Conversation

ArturMoczulski
Copy link
Contributor

@ArturMoczulski ArturMoczulski commented Apr 21, 2017

This PR covers #127

Added raw request body to the payload. This should be automatically scrubbed with changes coming from #126

@ArturMoczulski ArturMoczulski added this to the v1.0.0 Release milestone Apr 21, 2017
@ArturMoczulski ArturMoczulski changed the title GitHub Issue 127: Add the request body to the item payload GitHub Issue #127: Add the request body to the item payload Apr 21, 2017
@ArturMoczulski
Copy link
Contributor Author

This PR is failing to build in Travis due to a bug in tests/DataBuilderTest.php no related to the issue. The bug is fixed in #126 PHPUnit will be passing once both PRs come together.

@rokob
Copy link
Contributor

rokob commented Apr 21, 2017

This looks good, can you rebase on master now that #126 has been merged just so we can be sure the tests pass.

@rokob
Copy link
Contributor

rokob commented Apr 24, 2017

Is there some way we can ignore those style warnings in the mock?

@rokob
Copy link
Contributor

rokob commented Apr 25, 2017

Failure on hhvm only? That looks suspicious.

@ArturMoczulski
Copy link
Contributor Author

Yeah, I'm looking into it. Started setting up hhvm on my dev environment last night.

@ArturMoczulski
Copy link
Contributor Author

I'm still not exactly sure what's the convention for providing the level for log method. Some places use \Rollbar\Payload\Level::fromName() others the PHPUnit's LogLevel. However, both are static calls (to a method or a constant). Not sure how we would change this to not use static calls in this case.

… and stream_read is called in hhvm - in hhvm stream_read is not invoked unless stream_eof returns a valid value
@ArturMoczulski
Copy link
Contributor Author

This is ready for merge. HHVM is passing now.

@rokob
Copy link
Contributor

rokob commented Apr 27, 2017

🚀

@rokob rokob merged commit 17f43ac into rollbar:master Apr 27, 2017
@ArturMoczulski ArturMoczulski deleted the github-127-request-body branch April 29, 2017 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants