Fixing max_errno comparison operator to match docs #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs define the max_errno variable as "Max PHP error number to report. e.g. 1024 will ignore all errors E_USER_NOTICE or higher." This fix ensures that a setting of 1024 will ignore all errors of type E_USER_NOTICE. Previously a setting of 1024 would ignore only errors with a higher increment than specified. The documented behavior is more clear, therefore, the operator has been changed to match.
brianr
added a commit
that referenced
this pull request
Sep 6, 2012
Fixing max_errno comparison operator to match docs
bxsx
pushed a commit
that referenced
this pull request
Nov 2, 2021
…nfig Add missing transformer config option
This was referenced Apr 12, 2022
Merged
12 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs define the max_errno variable as "Max PHP error number to report. e.g. 1024 will ignore all errors E_USER_NOTICE or higher."
This fix ensures that a setting of 1024 will ignore all errors of type E_USER_NOTICE. Previously a setting of 1024 would ignore only errors with a higher increment than specified.
The documented behavior is more clear, therefore, the operator has been changed to match.