Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RollbarLogger::log() incompatible with Psr\Log\LoggerInterface::log() v1.0 #617

Closed
lukastaferner opened this issue Apr 12, 2023 · 1 comment · Fixed by #623
Closed

RollbarLogger::log() incompatible with Psr\Log\LoggerInterface::log() v1.0 #617

lukastaferner opened this issue Apr 12, 2023 · 1 comment · Fixed by #623
Assignees
@danielmorell
Labels
Rank: 1 - Critical Tackle above all other actionable requests. Type: Bug Fix a component so that its behavior aligns with its documentation.

Comments

@lukastaferner
Copy link

Dear Rollbar-Team,
Installing the package with psr/log:^1 produces the following error:
Fatal error: Declaration of Rollbar\RollbarLogger::log($level, Stringable|string $message, array $context = []): void must be compatible with Psr\Log\LoggerInterface::log($level, $message, array $context = []) in /srv/apache2/keepersport/vendor/rollbar/rollbar/src/RollbarLogger.php on line 194

Thank you!
@danielmorell danielmorell self-assigned this Apr 13, 2023
@danielmorell danielmorell added Rank: 1 - Critical Tackle above all other actionable requests. Type: Bug Fix a component so that its behavior aligns with its documentation. labels Apr 13, 2023
@Chris53897 Chris53897 mentioned this issue Apr 16, 2023
Closed
@Chris53897
Copy link
Contributor

(I am not from the rollbar team)
I am not sure if it is possible to support psr/log 1-3. I did two PR and i suggest to remove support for version 1.

danielmorell added a commit that referenced this issue Apr 20, 2023
@danielmorell
Fixed #617 RollbarLogger:log() not compatible with psr/log 1
258cf9b
@danielmorell danielmorell mentioned this issue Apr 20, 2023
Merged
12 tasks
danielmorell added a commit that referenced this issue Apr 21, 2023
@danielmorell
Merge pull request #623 from rollbar/fixed/617-psr-log-1-compatability
eb8b584 
Fixed #617 `RollbarLogger:log()` not compatible with psr/log 1
@danielmorell danielmorell mentioned this issue Apr 28, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielmorell danielmorell

Labels
Rank: 1 - Critical Tackle above all other actionable requests. Type: Bug Fix a component so that its behavior aligns with its documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed #617 RollbarLogger:log() not compatible with psr/log 1 rollbar/rollbar-php
3 participants
@Chris53897 @lukastaferner @danielmorell