Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ci tests for php 8.2, bump github actions versions, #84

Conversation

Chris53897
Copy link

remove travis.

The ci tests are improved that prefer-lowest does only run at the lowest supported php version.
Github actions are bumped, to get rid of deprecations messages (node12).

Type of change

  • Maintenance

Copy link
Collaborator

@danielmorell danielmorell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Chris53897! I am curious why not use prefer-lowest, prefer-stable on all versions of PHP?

@Chris53897
Copy link
Author

I learned that from Symfony Core developers. But i am not sure if i can find that github link again.
And by looking at other repos for have a look at good practices.
The main goal was that the lowest supported versions of libraries are only supported on the lowest supported php branch.
Not that somebody uses php 8.2 with the old version of libraries.
Test-Matrix get very big in some repos if you test it in every version.
But of course this PR could be split and just bump the github action versions.

Note for myself:
I changed it here Dukecity/CommandSchedulerBundle@bc4bc7e

Copy link
Collaborator

@danielmorell danielmorell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chris53897 looks good. Thank you!

@danielmorell danielmorell merged commit d8579d0 into rollbar:master Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants