Adds proxy server support. #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump. Any feedback on this PR? |
rokob
reviewed
Aug 23, 2017
lib/rollbar/notifier.rb
Outdated
| end | ||
|
|
||
| def null_proxy | ||
| OpenStruct.new(:host => nil, :port => nil, :user => nil, :password => nil) |
There was a problem hiding this comment.
Why OpenStruct and not just a plain struct? i.e.
Struct.new(:host, :port, :user, :password).new
There was a problem hiding this comment.
To be honest, this started life as a Struct, then an abandoned refactoring changed it to an OpenStruct and I neglected to change it back. Happy to do that. It makes this code more concise.
|
This seems like a reasonable change to me. |
printercu
reviewed
Nov 21, 2017
| @@ -8,6 +8,7 @@ | |||
| require 'rollbar/delay/thread' | |||
| require 'rollbar/logger_proxy' | |||
| require 'rollbar/item' | |||
| require 'ostruct' | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.