Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compatibility fixes for ActionMailer plugin #1146

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

waltjones
Copy link
Contributor

Description of the change

This PR fixes several compatibility issues with plugin support for ActionMailer.

  • Correctly detect whether included in a mailer class.
  • Report metadata available in subclasses of ActionMailer::Base, and don't reference attributes that aren't. (e.g. arguments)
  • Prevent double Rollbar reports, caused by the rescue_from handler getting called twice.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Related issues

Fixes: #1145

Copy link

@matux matux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@waltjones waltjones merged commit 9c00fdb into master Jan 11, 2024
25 checks passed
@lucasmazza
Copy link

I tested this with our app that has a test that fails with 3.5.0 and everything looks good. Thanks for fixing this ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NameError: undefined local variable or method `arguments' for an instance of xxxMailer
3 participants