fix: rescue exceptions in deploy tasks, allow deploy to continue (#983)

lib/rollbar/capistrano_tasks.rb

@@ -40,6 +40,9 @@ def deploy_task(logger, opts = {})
  capistrano_300_warning(logger)
  logger.info opts[:desc] if opts[:desc]
  yield
+
+ rescue StandardError => e
+ logger.error "Error reporting to Rollbar: #{e.inspect}"
  end
 
  def deploy_update(capistrano, logger, dry_run, opts = {})

spec/rollbar/capistrano_tasks_spec.rb

@@ -79,6 +79,17 @@
  end
  end
 
+ context 'when an an exception is raised' do
+ it "logs the error to the logger" do
+ expect(::Rollbar::Deploy).to receive(:report)
+ .and_raise('an API exception')
+
+ expect(logger).to receive(:error).with(/an API exception/)
+
+ subject.deploy_started(capistrano, logger, dry_run)
+ end
+ end
+
  context 'with --dry-run provided' do
  let(:dry_run) { true }
 
@@ -154,6 +165,17 @@
  end
  end
 
+ context 'when an an exception is raised' do
+ it "logs the error to the logger" do
+ expect(::Rollbar::Deploy).to receive(:update)
+ .and_raise('an API exception')
+
+ expect(logger).to receive(:error).with(/an API exception/)
+
+ subject.deploy_succeeded(capistrano, logger, dry_run)
+ end
+ end
+
  context 'with --dry-run provided' do
  let(:dry_run) { true }
  let(:deploy_id) { 123 }
@@ -251,6 +273,17 @@
  end
  end
 
+ context 'when an an exception is raised' do
+ it "logs the error to the logger" do
+ expect(::Rollbar::Deploy).to receive(:update)
+ .and_raise('an API exception')
+
+ expect(logger).to receive(:error).with(/an API exception/)
+
+ subject.deploy_failed(capistrano, logger, dry_run)
+ end
+ end
+
  context 'with --dry-run provided' do
  let(:deploy_id) { 123 }
  let(:dry_run) { true }