Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the base Ubuntu for CI to 20.04, and remove py 2.7, 3.4 #427

Merged
merged 5 commits into from
Jun 26, 2023

Conversation

danielmorell
Copy link
Collaborator

Description of the change

Ubuntu 18.04 is now deprecated as a GitHub Action runner. This updates the distribution the job runs on to ubuntu-latest.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

None

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@waltjones
Copy link
Contributor

If I remember correctly, python dependencies tend to be closely coupled with Ubuntu version, and having older pythons in the matrix is easier with older ubuntu. I might try using 20.04 instead of latest, and even then the oldest python versions may still have trouble.

@danielmorell
Copy link
Collaborator Author

The ubuntu-20.04 runner image supports Python 3.6 to 3.11 and Python 2.7 until May 15th, 2023. See https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2004-Readme.md#python. We may need to drop support for legacy Python versions.

@waltjones waltjones changed the title Updated the base Ubuntu for CI since 18.04 is now deprecated. Update the base Ubuntu for CI to 20.04, and remove py 2.7, 3.4 Jun 26, 2023
@waltjones waltjones merged commit 09a4c5c into master Jun 26, 2023
97 checks passed
@waltjones waltjones deleted the updated/ci-ubuntu-version branch June 26, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants