Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace unittest2 with unittest #420

Merged
merged 6 commits into from
Feb 24, 2023
Merged

Replace unittest2 with unittest #420

merged 6 commits into from
Feb 24, 2023

Conversation

brianr
Copy link
Member

@brianr brianr commented Feb 23, 2023 •
edited
Loading

Description of the change

Builds on #419

  • Replace unittest2 with unittest
  • Update language and framework versions in test matrix (added 3.10 and 3.11, updated framework versions, culled some very old framework versions, including old Twisted versions)

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

#340, #419

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

pgajdos and others added 4 commits February 23, 2023 21:30
@pgajdos @mcepl
remove unittest2
0831326 
unittest2 is not neccessary in python3
@mcepl
Replace unittest's assertRegex with six.assertRegex (not available in…
bcc024e 
… 2.7).

Also, bump the required version of six to 1.14.0 (for assertNotRegex).

Fixes #340.
@brianr
Merge branch 'remove_unittest2' into merge-pr419
fac4999
@brianr
unittest2 -> unittest
f83ef98
@brianr brianr mentioned this pull request Feb 23, 2023
Merged
@brianr
- Add python versions, update and refine framework versions
1ffda5c 
- Fix tests so that tests containing py3 syntax are skipped when running on py2
- Update CI matrix, get CI passing on full matrix
waltjones
waltjones approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@waltjones waltjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brianr brianr merged commit c3b6510 into master Feb 24, 2023
@brianr brianr deleted the merge-pr419 branch February 24, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waltjones waltjones waltjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brianr @waltjones @pgajdos @mcepl