Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned Python 2 CI tests to legacy version of dependencies #408

Merged
merged 7 commits into from
Jun 7, 2022

Conversation

danielmorell
Copy link
Collaborator

Description of the change

certifi is a package that helps validate SSL root certificates that we depend on. In the latest release it started using Python 3 syntax. Since we have always been using the latest version, our Python 2 CI tests started failing after the last release of certifi.

This PR pip installs certifi==2021.10.8 if our CI test matrix is testing on Python 2.7. This is not an ideal solution seeing that we will not be using up to date root certificates in our tests. However, that may be a compromise we are willing to make.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

None (see our latest failed action run)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@danielmorell danielmorell marked this pull request as draft May 31, 2022 20:29
Copy link
Collaborator

@pawelsz-rb pawelsz-rb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good, I think we need to start slowly thinking about stopping our support for python2. we will have a lot more problems with packages in the future.

@danielmorell
Copy link
Collaborator Author

Yeah. Not having up to date SSL root certs is kind of a big deal. I haven't thought of any great way to solve that.

@danielmorell danielmorell marked this pull request as ready for review June 3, 2022 12:50
…e. They

should exist in the environment and not be overridden by setuptools.
Copy link

@cyrusradfar cyrusradfar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@danielmorell danielmorell merged commit c0267cd into master Jun 7, 2022
@danielmorell danielmorell deleted the python_2_ci branch June 7, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants