Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Werkzeug version for Flask 0.x #376

Merged
merged 8 commits into from
May 20, 2021
Merged

Pin Werkzeug version for Flask 0.x #376

merged 8 commits into from
May 20, 2021

Conversation

bxsx
Copy link
Contributor

@bxsx bxsx commented May 19, 2021

Description of the change

On May 11, 2021, Werkzeug released a new 2.x version that are not compatible with Flask 0.x.

This PR pins compatible Werkzeug version to Flask 0.x to fix build issues:

  • Werkzeug >=0.7 and < 1.0

NOTE: We have successfully built Flask 0.x with Werkzeug 1.x so far, however according to the upstream, Flask 0.x requires Werkzeug >=0.7 and < 1.0, so for sanity this PR uses the same requirements.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

[ch85391]

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

On May 11, 2021 Jinja2 released a new major version 3.x that is not
compatible with older Flask versions.
@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #85391: [CI] Flask v0.x has started to fail on Python3.5+.

@bxsx bxsx changed the title Force installing Jinja2 >=2.4 and <3.0 for Flask 0.x Pins Jinja2 >=2.4 and <3.0 for Flask 0.x May 19, 2021
@bxsx bxsx changed the title Pins Jinja2 >=2.4 and <3.0 for Flask 0.x Pin Jinja2 >=2.4 and <3.0 for Flask 0.x May 19, 2021
@bxsx bxsx mentioned this pull request May 19, 2021
10 tasks
bxsx added 5 commits May 19, 2021 17:58
Looks it should work for Werkzeug <2.0 (at least we successfully built
with 1.0.1), however pining it to <2.0 similar to the upstream fix.
@bxsx bxsx changed the title Pin Jinja2 >=2.4 and <3.0 for Flask 0.x Pin compatible versions of 3rd party packages for Flask 0.x May 20, 2021
@bxsx bxsx self-assigned this May 20, 2021
@bxsx bxsx requested review from waltjones and diegov May 20, 2021 10:56
@bxsx bxsx changed the title Pin compatible versions of 3rd party packages for Flask 0.x Pin Werkzeug version for Flask 0.x May 20, 2021
@bxsx bxsx merged commit 6824d25 into master May 20, 2021
@bxsx bxsx deleted the bxsx/ch85391/fix-flask-ci branch May 20, 2021 19:34
@bxsx bxsx added this to the v0.16.0 milestone Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants