Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python3.3 build #374

Merged
merged 5 commits into from
May 6, 2021
Merged

Fix Python3.3 build #374

merged 5 commits into from
May 6, 2021

Conversation

bxsx
Copy link
Contributor

@bxsx bxsx commented May 5, 2021

Description of the change

Python 3.3 builds have started to fail when running python setup.py test that cannot retrieve 3rd party packages anymore.

This PR addresses this issue.

It also includes a minor refactor on using correct version of the mock package:
Install mock<=3.0.5 for Python 3.2- instead of Python 3.3- as unittest.mock has been added in Python3.3+

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix [ch84510]

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@bxsx bxsx changed the title Refactor tests dependencies Fix Python3.3 build May 5, 2021
@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #84510: Builds for Python3.3 with Flask/Django fail.

@bxsx bxsx merged commit 132d5c9 into master May 6, 2021
@bxsx bxsx deleted the bxsx/setup-refactor branch May 6, 2021 12:26
@bxsx bxsx added this to the v0.16.0 milestone Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants