Collect the user IP from X-Forwarded-For, then falls back to X-Real-Ip #370
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
The user IP will be taken from the X-Forwarded-For before checking X-Real-Ip to receive more accurate information if available.
Also, the current state of the sequence for checking the IP is not consistent across all supported frameworks.
This PR solves both issues.
I'm marking it as a breaking change as the final user IP in a payload may be different in some cases. However, this change shouldn't affect user code, and in most cases shouldn't be even noticeable.
Type of change
Checklists
Development
Code review