Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No option to set code_version at the config level in v5 of the SDK #630

Closed
tattan opened this issue Apr 11, 2022 · 9 comments · Fixed by #631
Closed

No option to set code_version at the config level in v5 of the SDK #630

tattan opened this issue Apr 11, 2022 · 9 comments · Fixed by #631
Assignees
Labels
enhancement Denotes SDK enhancement related task question

Comments

@tattan
Copy link

tattan commented Apr 11, 2022

Is your feature request related to a problem? Please describe.
In v4 of the SDK this issue was created #13 and fixed. I was looking for a way to do that or something similar in v5 of the SDK

Describe the solution you'd like
I'd like to be able to include code_version (not server code_version) at either the RollbarInfrastructureConfig or RollbarLoggerConfig.

Describe alternatives you've considered
Having a custom wrapper that takes a Body and sets the version for each rollbar item to be sent.

@akornich akornich self-assigned this Apr 11, 2022
@akornich
Copy link
Contributor

@tattan , actually it looks like #13 and #14 happened during v0 of the SDK.
Let me see what we can do here...

@akornich
Copy link
Contributor

akornich commented Apr 12, 2022

@tattan , for now, you can probably define your own payload transform action here so you can assign the desired code version to every processed payload...

@akornich
Copy link
Contributor

@tattan , now as a long-term solution, what if I add new nullable CodeVersion property here and will be assigning to every payload's Data.CodeVersion if defined (not null)?

@akornich akornich added the enhancement Denotes SDK enhancement related task label Apr 12, 2022
@tattan
Copy link
Author

tattan commented Apr 12, 2022

@akornich I think your long-term solution would be great. I'll implement a transform in the meantime. Thank you

@DrewSaucier
Copy link

@akornich do you have a timeline on this request. We are bumping up against as well in v4 to v5 updating.

Thank you!

@akornich
Copy link
Contributor

@DrewSaucier , I'll try to have it out sometime this week.

akornich added a commit to WideSpectrumComputing/Rollbar.NET that referenced this issue May 17, 2022
@akornich akornich mentioned this issue May 17, 2022
12 tasks
akornich added a commit that referenced this issue May 17, 2022
@akornich
Copy link
Contributor

now available in v5.2.0...

@tattan
Copy link
Author

tattan commented Jun 3, 2022

Hi @akornich, the proposed solution was implemented to spec but did not have the same effect as setting code_version in the root of the json body.

Setting notifier.infrastructure_options.RollbarloggerConfig.RollbarPayloadAdditionOptions.CodeVersion and notifier.configured_options.RollbarPayloadAdditionOptions.CodeVersion does not update the github (in our case) link displayed in the code_version column.

For now we are continuing to use a transform to achieve the desired result but I wanted to know if your intent was to have the sha sum set correctly and the link to source control generated when a given occurrence is sent as it is if you send a sha value for code_version in the root of the payload.

@DrewSaucier
Copy link

DrewSaucier commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Denotes SDK enhancement related task question
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants