Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure 'simpleclip-custom-content-provider is non-nil before using it. #17

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

djl
Copy link
Contributor

@djl djl commented Apr 6, 2021

Fixes an issue introduced in #15.

Before this fix 'simpleclip-custom-content-provider was always used because it only checked that the variable was bound instead of checking for a non-nil value.

(boundp 'simpleclip-custom-content-provider)
;; t
simpleclip-custom-content-provider
;; nil

This resulted in always running an empty shell command.

A cleaner way might to be to only check for a non-nil value since if it's non-nil, 'bound-p will return true.

@rolandwalker
Copy link
Owner

Hi!

Makes sense.

@rolandwalker rolandwalker merged commit 67c8c17 into rolandwalker:master Apr 6, 2021
@djl djl deleted the fix-nil-custom branch April 14, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants